Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegate: fix zone configs for SHOW CREATE TABLE with no partitions #65167

Merged
merged 1 commit into from
May 14, 2021

Conversation

otan
Copy link
Contributor

@otan otan commented May 13, 2021

Fixed the regression in c44619c which
had no tests to cover this case.

Release note (bug fix): Fixed a bug where if the zone configurations
would not display on a SHOW CREATE TABLE if there are no partitions
even though there are zone configurations on the index or tables
themselves.

@otan otan requested review from jordanlewis and a team May 13, 2021 22:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇

Fixed the regression in c44619c which
had no tests to cover this case.

Release note (bug fix): Fixed a bug where if the zone configurations
would not display on a SHOW CREATE TABLE if there are no partitions
even though there are zone configurations on the index or tables
themselves.
@otan
Copy link
Contributor Author

otan commented May 13, 2021

tftr!

bors r=jordanlewis

@craig
Copy link
Contributor

craig bot commented May 14, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants